Add clang_tidy bazel rule with example #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wojciech Madry <[email protected]>
…json Signed-off-by: Wojciech Madry <[email protected]>
|
Hi, thanks for the MR. I really like that this moves the check from the aspect build to a test step, because of the reasons in #15. Perhaps we should eventually move to this approach. I do not like the excess duplication of code - is there a reasonable way to reduce that? |
|
I think so, I can try next week to make python functions public so they can be imported. |
Signed-off-by: Wojciech Madry <[email protected]>
|
Hi, @erenon, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I created a bazel rule so that it can be used as described in the readme.
This is not exactly the same solution, but the issue is mentioned here: #15
It is not perfect code, I created it for my own needs, but I think it can be a good base for future development.
I'm just sharing this, maybe it will be useful to someone.